wip: Oracle Cloud support - #871
Conversation
3e045be to
d48af83
Compare
d48af83 to
367367a
Compare
|
private ipv4 & public ip is not exposed via afterburn in Oracle which is required for some tests. So I need to add it upstream. For now I will use systemd hack. Correct me if I am mistaken. @tormath1 https://github.com/coreos/afterburn/blob/main/docs/usage/attributes.md#metadata-attributes |
|
I think my PR is ready. Let me know what else to implement. |
tormath1
left a comment
There was a problem hiding this comment.
Thanks a lot, overally it looks good. I just have one request, usually the ore command is used to create and upload an image on the cloud provider. Is that possible to implement this?
It's then used like that: https://github.com/flatcar/scripts/blob/d2c217cb741debc9becda0bda86347319f17a65c/ci-automation/vendor-testing/stackit.sh#L24-L48
We first upload the image then we use the resulting image ID in the kola run command.
|
Done, tested ore image uploads. Added retry also, using
|
tormath1
left a comment
There was a problem hiding this comment.
Looks good, thanks! I'll give a try in the CI.
| }, nil | ||
| } | ||
|
|
||
| func (a *API) WaitForInstanceState(ctx context.Context, instanceID string, state core.InstanceLifecycleStateEnum) (*core.Instance, error) { |
There was a problem hiding this comment.
Do we still need all of this now we use the OCI Retry mechanism?
If yes, let's just use the Mantle implementation:
$ go doc util.Retry
package util // import "github.com/flatcar/mantle/util"
func Retry(attempts int, delay time.Duration, f func() error) error
Retry calls function f until it has been called attemps times, or succeeds.
Retry delays for delay between calls of f. If f does not succeed after
attempts calls, the error from the last call is returned.
There was a problem hiding this comment.
Checked the OCI Retry mechanism but it is too verbose, so using mantle's util.Retry for simpler approach. WaitForInstanceState wrappers are needed for nice error formatting.
|
Tests results:
From 7f1b6e64cea41b85546c0ff6e4a9ccf6614b8f79 Mon Sep 17 00:00:00 2001
From: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Date: Thu, 20 Aug 2026 10:42:52 +0200
Subject: [PATCH] kola/tests: remove oraclecloud for cloudinit tests
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
---
kola/tests/misc/cloudinit.go | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kola/tests/misc/cloudinit.go b/kola/tests/misc/cloudinit.go
index cb6ff82a5..1f4a17b77 100644
--- a/kola/tests/misc/cloudinit.go
+++ b/kola/tests/misc/cloudinit.go
@@ -158,7 +158,8 @@ write_files:
Distros: []string{"cl"},
// Hetzner: we need to implement coreos-cloudinit support for Hetzner.
// Akamai: we need to implement coreos-cloudinit support for Akamai.
- ExcludePlatforms: []string{"qemu-unpriv", "hetzner", "akamai"},
+ // Oraclecloud: we need to implement coreos-cloudinit support for Oraclecloud.
+ ExcludePlatforms: []string{"qemu-unpriv", "hetzner", "akamai", "oraclecloud"},
// This should run on all clouds
})
register.Register(®ister.Test{
--
2.54.0and solve this: #871 (comment) |
Signed-off-by: Navaneeth <me@rizexor.com>
Signed-off-by: Navaneeth <me@rizexor.com>
Signed-off-by: Navaneeth <me@rizexor.com>
Signed-off-by: Navaneeth <me@rizexor.com>
Signed-off-by: Navaneeth <me@rizexor.com>
Signed-off-by: Navaneeth Rao <me@rizexor.com>
Signed-off-by: Navaneeth Rao <me@rizexor.com>
Signed-off-by: Navaneeth Rao <me@rizexor.com>
Signed-off-by: Navaneeth Rao <me@rizexor.com>
Signed-off-by: Navaneeth Rao <me@rizexor.com>
Signed-off-by: Navaneeth Rao <me@rizexor.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Co-authored-by: Mathieu Tortuyaux <mathieu.tortuyaux@gmail.com> Signed-off-by: Navaneeth Rao <me@rizexor.com>
Signed-off-by: Navaneeth Rao <me@rizexor.com>
Signed-off-by: Navaneeth Rao <me@rizexor.com>
Signed-off-by: Navaneeth Rao <me@rizexor.com>
Co-authored-by: Mathieu Tortuyaux <mathieu.tortuyaux@gmail.com> Signed-off-by: Navaneeth Rao <me@rizexor.com>
Signed-off-by: Navaneeth Rao <me@rizexor.com>
53bfe12 to
da92947
Compare
|
Done |
Adds Oracle Cloud Testing Support
Adds Oracle Cloud Testing Support.